Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): Put "Other" and "None" last in Trends results #21233

Merged
merged 9 commits into from
Apr 4, 2024

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Mar 28, 2024

Problem

ZEN-11967 is partly about "Other" and "None" being confusing.
There were two issues:

  1. It's hard to notice these special no-values when appear in the middle of actual values. This especially goes for "Other".
  2. We were quite inconsistent with displaying those no-values, e.g. sometimes saying "none", elsewhere "None", and sometimes "None (No value)".

Changes

  1. Other and None are now always last, with Other being last-most.
  2. Other is always displayed as "Other (i.e. all remaining values)" and None is "None (i.e. no value)" for full clarity.

How did you test this code?

TODO

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Size Change: +71 B (0%)

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 824 kB +71 B (0%)

compressed-size-action

@Twixes Twixes marked this pull request as ready for review April 2, 2024 17:32
@Twixes Twixes requested a review from Gilbert09 April 2, 2024 17:32
@Twixes Twixes merged commit 56a72bb into master Apr 4, 2024
85 checks passed
@Twixes Twixes deleted the put-other-last branch April 4, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants